avcodec/alac: don't fail if channels aren't set during init() when extradata is valid
authorJames Almer <jamrial@gmail.com>
Fri, 29 Jul 2022 21:05:51 +0000 (18:05 -0300)
committerSebastian Ramacher <sramacher@debian.org>
Tue, 2 Aug 2022 18:27:24 +0000 (19:27 +0100)
The decoder is meant to use it as a fallback if the value in extradata is
invalid.

Regression since d199099be.

Signed-off-by: James Almer <jamrial@gmail.com>
Gbp-Pq: Name 0003-avcodec-alac-don-t-fail-if-channels-aren-t-set-durin.patch

libavcodec/alac.c

index 9aaf7066b28788204633f4988af4781618334286..4aab82d60b784f757f315e2738b3a7bb6d19a5fb 100644 (file)
@@ -574,13 +574,15 @@ static av_cold int alac_decode_init(AVCodecContext * avctx)
     avctx->bits_per_raw_sample = alac->sample_size;
     avctx->sample_rate         = alac->sample_rate;
 
-    if (alac->channels < 1 || alac->channels > ALAC_MAX_CHANNELS) {
+    if (alac->channels < 1) {
         av_log(avctx, AV_LOG_WARNING, "Invalid channel count\n");
+        if (avctx->ch_layout.nb_channels < 1)
+            return AVERROR(EINVAL);
         alac->channels = avctx->ch_layout.nb_channels;
     }
-    if (avctx->ch_layout.nb_channels > ALAC_MAX_CHANNELS || avctx->ch_layout.nb_channels <= 0 ) {
+    if (alac->channels > ALAC_MAX_CHANNELS) {
         avpriv_report_missing_feature(avctx, "Channel count %d",
-                                      avctx->ch_layout.nb_channels);
+                                      alac->channels);
         return AVERROR_PATCHWELCOME;
     }
     av_channel_layout_uninit(&avctx->ch_layout);